docs for credential refresh / issuance for PoH#38
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3c397847db
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This reverts commit d214306.
| "group": "Sign in with World ID", | ||
| "pages": ["world-id/sign-in/oidc"] | ||
| }, | ||
| { |
There was a problem hiding this comment.
let's create a new section altogether for the PoH Issuer. @andy-t-wang sg?
| - **App ID**: The ID of your app that is assigned in our [Developer Portal](https://developer.worldcoin.org/). | ||
| - **Action**: A developer-facing primitive that lets you put any app operation behind a unique-human gate. An app can have one or more actions depending on your use case. | ||
| - **Issuer**: An entity authorized to issue a credential for a specific schema. Issuers sign credentials and publish their public keys in the `CredentialSchemaIssuerRegistry`. | ||
| - **Credential**: A signed attestation about a subject used to generate proofs. It includes issuer, subject, validity window, and claim commitments as defined in the [World ID 4.0 specs](https://github.com/worldcoin/world-id-protocol/tree/main/docs/world-id-4-specs) |
There was a problem hiding this comment.
let's point instead to the source of truth for what is a credential, https://docs.rs/world-id-primitives/latest/world_id_primitives/credential/struct.Credential.html
| "twitter:image": "/images/docs/docs-meta.png" | ||
| --- | ||
|
|
||
| This endpoint issues a new proof-of-human (PoH) credential to a holder of a valid World ID. It can re-verify with a Personal Custody Package (PCP) or issue a credential-only refresh when a PCP is not available. |
There was a problem hiding this comment.
It's not clear that this endpoint is only intended for v3 users to get their v4 credential
| - **Issuer public key** (`issuer.pk`) is serialized as `[x, y]` decimal strings for BabyJubJub affine coordinates. | ||
| - **Signature** is hex-encoded compressed bytes (no `0x` prefix). | ||
|
|
||
| ### PoH-specific claims |
There was a problem hiding this comment.
this is super important to document, but let's keep it only in a single place
| ] | ||
| }, | ||
| { | ||
| "tab": "PoH Issuer", |
There was a problem hiding this comment.
| "tab": "PoH Issuer", | |
| "tab": "Proof of Human Credential", |
| "og:image": "/images/docs/docs-meta.png" | ||
| "twitter:image": "/images/docs/docs-meta.png" | ||
| --- | ||
|
|
There was a problem hiding this comment.
this can be tackled in a separate PR but in general we should introduce the PoH credential. @andy-t-wang probably someone from your team can support
|
|
||
| If PCP validation fails, the endpoint returns an error status with `PCP_VALIDATION_FAILED`. | ||
|
|
||
| ## Credential object format |
There was a problem hiding this comment.
instead of having the entire payload here which may change (e.g. the encoding of the issuer pk already changed), I would only document the issuer_schema_id = 1, what each claim represents (only claim[0] used), and empty associated data hash
This reverts commit ce23546.
2 participants
Summary